This repository was archived by the owner on Dec 24, 2025. It is now read-only.
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the flet-datatable2 library to improve API consistency and maintainability. The changes primarily focus on modernizing the DataColumn2 constructor to use keyword-only arguments and updating all usages to explicitly specify the label parameter.
- Convert DataColumn2 to use keyword-only arguments for better API clarity
- Update all DataColumn2 instantiations to use explicit
labelparameter - Improve project configuration with better dependency management and documentation tooling
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/flet_datatable2/datacolumn2.py | Added kw_only=True to DataColumn2 control decorator |
| tests/sorting_test.py | Updated DataColumn2 calls to use label= parameter and fixed event type/callback name |
| tests/basic_test.py | Updated DataColumn2 calls to use explicit label= parameter |
| examples/datatable2_example/src/example-1.py | Updated DataColumn2 calls to use explicit label= parameter |
| examples/datatable2_example/src/example-2.py | Updated DataColumn2 calls to use explicit label= parameter |
| src/flet_datatable2/init.py | Added all list for better module exports |
| pyproject.toml | Reorganized dependency groups and updated versions |
| mkdocs.yml | Updated documentation configuration and plugin settings |
| .pre-commit-config.yaml | Added pre-commit configuration file |
| .github/workflows/docs.yml | Updated GitHub Actions workflow for documentation |
| src/flet_datatable2/datatable2.py | Reformatted field definitions for better readability |
FeodorFitsner
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.